build: create a private package for shared eslint configs #11240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
jcfranco
approved these changes
Jan 9, 2025
jcfranco
added
the
skip visual snapshots
benelan
changed the title
|
@jcfranco can you take another look at this? I significantly reworked the PR since your approval. @alisonailea can you take a quick look at the design tokens package changes as well? |
jcfranco
approved these changes
Jan 11, 2025
| @@ -14,6 +14,7 @@ function deeplyNestedColorValue(val) { | |||
|
|
|||
| if (val.includes("rgba") || color.getAlpha() === 0) { | |||
| const hexMatch = val.match(/#[\w\d]{3,6}/g); | |||
| // eslint-disable-next-line no-useless-escape | |||
There was a problem hiding this comment.
Can you add an explainer to this disabled line? Applies to other disabled rules.
…mprovements * origin/dev: fix(input): update files property on input event when type="file" (#11262)
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
packages/eslint-config-calcitethat contains shared ESLint configurations for importing in other packages.no-unexpected-newline, which conflicts with prettier.vscode/and removing cspell ignore comments in favor of dictionary additions..npm run lintso unrelated changes don't appear in subsequent PRs